#3757 Split requirements/pip.txt #3767
Conversation
There was a problem hiding this comment.
Thanks for the PR!
I think it's close enought to get merged. Please, take a look at the small comments that I left.
Althought, when I linked the python_environment.py file I realize that even when we use LocalBuildEnvironment we install the default packages using Virtualenv.install_core_requirements so, now I'm wondering if we need this packages at all.
| docutils==0.11 | ||
| Sphinx==1.5.3 | ||
| sphinx_rtd_theme==0.2.5b1 | ||
| readthedocs-build<2.1 |
There was a problem hiding this comment.
This one is needed in pip.txt since it's used to parse the YAML file even when the docs are built under Docker.
| @@ -0,0 +1,9 @@ | |||
| mkdocs==0.14.0 | |||
There was a problem hiding this comment.
We should match all the versions that we are installing here with the ones that we are installing by default at
|
Can you make the changes here in this PR? Otherwise it difficult to review and confusing. |
|
Actually I messed up the code in the local repo trying to make it in sync with the repo at readthedocs.org, resulting in complete deletion of the repo. I had to reclone the repository. |
No description provided.