-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
#3718: Added date to changelog #3727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,6 @@ | ||
| {{header}} | ||
| {{toHeader header "-"}} | ||
| Date: {{date}} | ||
|
|
||
| {{#issues}} * `@{{user.login}} <http://github.com/{{user.login}}>`_: {{title}} (`#{{number}} <{{html_url}}>`_) | ||
| {{/issues}} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ description = Read the Docs builds and hosts documentation | |
| author = Read the Docs, Inc | ||
| author_email = [email protected] | ||
| url = http://readthedocs.org | ||
| classifiers = | ||
| classifiers = | ||
| Development Status :: 5 - Production/Stable | ||
| Environment :: Web Environment | ||
| Intended Audience :: Developers | ||
|
|
@@ -23,4 +23,3 @@ classifiers = | |
| packages = find: | ||
| include_package_data = True | ||
| zip_safe = False | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need a newline before this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im so sorry but I have deleted the branch via which I had made changes. Shall I make a new pull request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think is better to continue the PR on this branch, so we don't lost the review... Maybe you don't have an option on the bottom like
restore branchor something?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Im sorry but I think I've lost the branch that i worked upon.. its not showing in my repo 😢 are you sure I shall not create a new PR, because its just a single line of code that has been changed :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you search if there is a way of restoring your previous branch first? Please. I see that all your PRs were affected. If not, making a new PR makes sense here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stsewd I am sorry for the mess i've made here. even my PR on issue #3757 have been a mess because of this. I googled for the solution but was not able to find any. The main issue was that i deleted the forked repo from my profile (i know thats dumb). Please allow me a new PR and I will keep in mind these things in future. Again, I am so sorry for the inconvenience caused to you :(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry too much about that, it's fine creating a new PR and linking that one here.