#3718: Added date to changelog #3727
Conversation
setup.cfg
Outdated
| @@ -1,6 +1,6 @@ | |||
| [metadata] | |||
| name = readthedocs | |||
| version = 2.2.1 | |||
| version = build | |||
There was a problem hiding this comment.
What is the implication in changing this?
There was a problem hiding this comment.
I didn't changed it.. It got automatically changed when i ran invoke prepare build ... Looks like I had to pass version number in place of build.
contrib/changelog.hbs
Outdated
| @@ -1,4 +1,4 @@ | |||
| {{header}} | |||
| {{header}} - {{date}} | |||
| {{toHeader header "-"}} | |||
There was a problem hiding this comment.
The toHeader must receive the same above text, so that they have the same width
There was a problem hiding this comment.
Do i need to re submit the code?
There was a problem hiding this comment.
Just do the requested changes on this same branch and do push again, GitHub will update the PR automatically :). Let me know if you need more help.
CHANGELOG.rst
Outdated
| @@ -1,3 +1,48 @@ | |||
| Version build - March 04, 2018 | |||
There was a problem hiding this comment.
I think there is no need to add the changelog here, but looks great how is generated now :)
There was a problem hiding this comment.
Thank you... But hope I didn't messed up anything in my first attempt :P
There was a problem hiding this comment.
It's ok, just revert the version number, delete the changelog file and take a look to my other comment. Then I think it's ready to get merged! Thanks for you interest on collaborating.
|
hi @stsewd , I just wanted to know the status of this PR. Are there any additional changes to be made here? |
|
@rajujha373 seems fine to me, we only need to wait to rtd team for a review. Can you upload a sample file of how the current changelog will look like? |
|
please have a look @stsewd |
| @@ -1,5 +1,6 @@ | |||
| {{header}} | |||
| {{toHeader header "-"}} | |||
| Date: {{date}} | |||
There was a problem hiding this comment.
Im so sorry but I have deleted the branch via which I had made changes. Shall I make a new pull request?
There was a problem hiding this comment.
I think is better to continue the PR on this branch, so we don't lost the review... Maybe you don't have an option on the bottom like restore branch or something?
There was a problem hiding this comment.
Im sorry but I think I've lost the branch that i worked upon.. its not showing in my repo 😢 are you sure I shall not create a new PR, because its just a single line of code that has been changed :(
There was a problem hiding this comment.
Can you search if there is a way of restoring your previous branch first? Please. I see that all your PRs were affected. If not, making a new PR makes sense here.
There was a problem hiding this comment.
@stsewd I am sorry for the mess i've made here. even my PR on issue #3757 have been a mess because of this. I googled for the solution but was not able to find any. The main issue was that i deleted the forked repo from my profile (i know thats dumb). Please allow me a new PR and I will keep in mind these things in future. Again, I am so sorry for the inconvenience caused to you :(
There was a problem hiding this comment.
Don't worry too much about that, it's fine creating a new PR and linking that one here.
|
Closing in favor of #3788. Thank you, @rajujha373, and thanks for sticking with it and figuring out the solution to the PR fiasco! |
|
I should thank you guys for letting me continue with it ... lol @RichardLitt |
This is my first pull request to readthedocs repo. Do guide me in case of any discrepency. Thank You :)