-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Add "edit" and "view docs" buttons to subproject list #3572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "edit" and "view docs" buttons to subproject list #3572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice improvement although in some cases users might find helpful to easily see the URL. Maybe make it on a new line but not clickable? This would probably look best slightly greyed and without an underline. But this is just an idea and would like to hear what other people have to say before you change it.
I like what @stsewd propose here since it's like the common UX all around RTD. Regarding seeing the URL, I don't have strong thoughts on that. I'll probably just hover the "View Docs" link in that case and check the URL in the bottom of my Firefox. I didn't use too much subprojects but the importance on this (show/hide that URL) will depend on the use case. I wouldn't use it, I think :) |
Parts of this UI are a move to standardize on our UX, so some notes:
The project import page is an example of what other tables will become: multiple lines if necessary, one primary button that is an icon, subtle text hints for secondary information. The subproject page was a first pass at this feature and no attempt was made to add styling then. Each row does need an edit button, but I think this is dropping some necessary pieces. |
@agjohnson I have improved the styles and the layout as suggested, please tell me what you think. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! This looks great for me.
Although, I can't judge the CSS code since I think we are using LESS for ir and I don't have experience. I suppose that you shouldn't touch the core.css
file since this one should be auto-generated by LESS from a core.less
file maybe.
No the edits to the css file are correct. It looks like they are not generated from a sass file. Maybe something we want to do in the future? |
@humitos as @Blendify mention, this isn't an auto generated file. A review for the css from @agjohnson would be awesome here, since I just based on some previous styles. |
I suppose that this is the path to follow, but I don't have the knowledge to have an opinion :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks very good from my point of view. Thanks!
@@ -12,7 +12,7 @@ | |||
{% block project_edit_content_header %}{% trans "Subprojects" %}{% endblock %} | |||
|
|||
{% block project_edit_content %} | |||
<p> | |||
<p class="help_text"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was missing here :)
Tested this locally and it's 💯. |
Closes #3538
Before
After