Skip to content

Improve project translation listing under admin tab #3708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
humitos opened this issue Mar 1, 2018 · 9 comments · Fixed by #5380
Closed

Improve project translation listing under admin tab #3708

humitos opened this issue Mar 1, 2018 · 9 comments · Fixed by #5380
Labels
Design Design or UX/UI related Improvement Minor improvement to code Needed: design decision A core team decision is required
Milestone

Comments

@humitos
Copy link
Member

humitos commented Mar 1, 2018

Currently, under Admin -> Translations tab we have something like this to list "Existing translations"

captura de pantalla_2018-03-01_09-14-23

I think we want to change this to feel more like the rest of the site (considering some improves that @stsewd has already done in other pages with listings --like redirects)

captura de pantalla_2018-03-01_09-16-23

(I took this image from Project Import, but it's just to share the idea)

@humitos humitos added Design Design or UX/UI related Improvement Minor improvement to code labels Mar 1, 2018
@humitos humitos added this to the Admin UX milestone Mar 1, 2018
@stsewd
Copy link
Member

stsewd commented Mar 1, 2018

We need to wait to #3572 gets approved/merged so we can reuse the css classes.

@stale
Copy link

stale bot commented Jan 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status: stale Issue will be considered inactive soon label Jan 10, 2019
@stsewd stsewd added Accepted Accepted issue on our roadmap and removed Status: stale Issue will be considered inactive soon labels Jan 10, 2019
@saadmk11
Copy link
Member

Can I Work on This Issue?

@humitos
Copy link
Member Author

humitos commented Mar 4, 2019

@saadmk11 I'd double check with @agjohnson or @ericholscher that my proposal is what we want before start working on it. I'm pinging them here looking for the 👍 of one of them.

@humitos humitos added Needed: design decision A core team decision is required and removed Accepted Accepted issue on our roadmap labels Mar 4, 2019
@saadmk11
Copy link
Member

saadmk11 commented Mar 4, 2019

@saadmk11 I'd double check with @agjohnson or @ericholscher that my proposal is what we want before start working on it. I'm pinging them here looking for the of one of them.

Okay Sure.

@agjohnson
Copy link
Contributor

agjohnson commented Mar 12, 2019

Yeah, all our admin forms should follow the new pattern. #3572 looks like a good base, I'd also look at how we implement the rest of the form for the page, as we have old forms that tried to be a list view and an edit view in a single page. The newer versions of admin pages don't do this and instead use a separate page for add/edit operations.

@saadmk11
Copy link
Member

I saw a few admin pages use the Old Pattern (Form and List view at the same time). I would like to propose to change the Old pattern with the new one as suggested by @agjohnson.
I was able to Find these pages using the old pattern:

  1. Domains
  2. Maintainers
  3. Redirects
  4. Translations
  5. Notifications

And I would also like to address the Environment Variables page should have a remove button on the list view which is used in the new pattern.
I would like to work on this if this gets accepted.
and please feel free to add any corrections to my proposal.
if I understood it incorrectly please correct me.

@agjohnson
Copy link
Contributor

It would be best to split this all into digestible chunks either way, but 👍 on addressing the old pattern use in all of our forms. We are about to start a contract that will address the UX and styling on these forms, so this part is not as important as having all the correct views and form handling.

@saadmk11
Copy link
Member

@agjohnson If I understood you correctly, you want to split the old pattern views (different views for list, create/update form) so that it matches the new pattern. Such as the subproject views in the project Admin
https://github.com/rtfd/readthedocs.org/blob/b06dedb5bf008d5d835110faa6176c24146546f1/readthedocs/projects/views/private.py#L484-L503
If I'm correct we can start working on this in small pieces (page by page) and test it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Design Design or UX/UI related Improvement Minor improvement to code Needed: design decision A core team decision is required
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants