Improve error reporting to users #3244
Closed
+211
−135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up logging around exceptions
This is to make architecture the top link after changelog and installation instructions. Also moves API to the bottom, because it stands out of the reading flow, which is: - see if the development thing you think about is already done - launch installation if you're going to fix anything - (or) read about archtecture - about testing, probably installation is ready - how to sync docs - standards, etc. - components (should be linked from archtecture) - everything else - leave API pages open
Rearrange development docs ToC
* Use new Celery, use new application pattern * Use modern celery * Drop djcelery * New pattern for starting celery * Bump redis to 2.10.6 to avoid startup bug, change autodiscover call * Update docs mentioning Celery * Goof on package name * Missed djcelery import * Fix rebased task that was missed * Handle change to Celery group calls in 4.x * Fix tests * Fix up some linting issues and problems starting the application * Fix celery task registration * We don't need shared_task anymore, swap for readthedocs.worker.app.task * Fix call to chord
Because it is not discovered - https://travis-ci.org/rtfd/readthedocs.org/jobs/300125610#L793
This should make us a lot more resilient to failures, specifically when *one* web server is acting up.
agjohnson
force-pushed
the
improve-task-error-reporting
branch
from
f25ac2d to
3da4cc0
Compare
|
Pushed up a rebase, but this PR is still being merged into the |
|
Moved to #3247 |
|
You can change the base on where the PR goes, FWIW> |
|
Aha, i didn't realize that was a feature 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets us hopefully catch both more useful and more errors