Use new Celery, use new application pattern #3237
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
agjohnson
commented
Nov 8, 2017
agjohnson
commented
- Use modern celery
- Drop djcelery
- New pattern for starting celery
- Bump redis to 2.10.6 to avoid startup bug, change autodiscover call
* Use modern celery * Drop djcelery * New pattern for starting celery * Bump redis to 2.10.6 to avoid startup bug, change autodiscover call
agjohnson
force-pushed
the
upgrade-celery-pattern
branch
from
c82a9aa to
b0c3ad5
Compare
safwanrahman
reviewed
Nov 9, 2017
readthedocs/projects/tasks.py
Outdated
| @@ -572,7 +569,7 @@ def update_imported_docs(version_pk): | |||
|
|
|||
|
|
|||
| # Web tasks | |||
| @task(queue='web') | |||
| @shared_task(queue='web') | |||
There was a problem hiding this comment.
I dont like using shared_task unless its a reusable app where you can not get the app.
You can import the app from worker then use the decorator task
something like
from readthedocs.worker import app
@app.task(queue='web')There was a problem hiding this comment.
There was a problem hiding this comment.
Makes sense, I'll try the change.
|
Think we've been through this PR a few ways now. I'll get this merged |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.