Switch to static SVG badges #3057
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this @jerivas! If you want to fix the linting issue, I'll get it merged & deployed. I'll give ya a couple days, and then fix it myself if I don't hear from ya :) |
readthedocs/projects/views/public.py
Outdated
| @@ -105,36 +106,23 @@ def get_context_data(self, **kwargs): | |||
| @never_cache | |||
| def project_badge(request, project_slug): | |||
| """Return a sweet badge for the project""" | |||
| BADGE_PATH = "projects/badges/%s.svg" | |||
There was a problem hiding this comment.
linting says this should be lower case.
There was a problem hiding this comment.
I also believe this probably needs to have a MEDIA_URL prepended to it, for production.
Nevermind, I missed the static call :)
|
Just committed the fix 😄 |
|
Thanks! :) |
|
This removes support for the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This completely removes the shields.io dependency and simply serves badges as static SVGs. The badges no longer display the version slug, they just show the "unknown", "passing", and "failing" status, with the appropriate color.
Docs have also been updated.