Skip to content

Support different badge styles #3509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wmayner opened this issue Jan 12, 2018 · 3 comments
Closed

Support different badge styles #3509

wmayner opened this issue Jan 12, 2018 · 3 comments
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code Sprintable Small enough to sprint on

Comments

@wmayner
Copy link
Contributor

wmayner commented Jan 12, 2018

Details

PR #3057 incidentally removed support for different badge styles that were available via https://shields.io/ querystrings. In projects that have badges from other services with other styles, this makes it more difficult to use a consistent badge style.

I will try to implement a PR for this if maintainers think it would be merged.

Expected Result

https://readthedocs.org/projects/pyphi/badge/?version=stable&style=flat-square should return a badge without rounded edges.

Actual Result

Only badges with rounded corners are available.

@wmayner wmayner added Good First Issue Good for new contributors Improvement Minor improvement to code Sprintable Small enough to sprint on labels Jan 12, 2018
@agjohnson
Copy link
Contributor

This seems reasonable. I would avoid adding any UX around this feature in RTD, but I think if users want to customize the badge via URL hacks, that is absolutely okay. I'm not sure if it makes sense to send a pruned list of query string args or not. I'd prefer pruning if we don't anticipate a lot of maintenance around the expected arguments. My only concern is that we're acting as a potentially malicious proxy to shields.io, so pruning might be good idea.

@fenilgandhi
Copy link
Contributor

So, from what i understand, we can have different static badges in the media static folder and then they can be url pruned. This way we get different styles while not being dependent on https://shields.io

@stsewd
Copy link
Member

stsewd commented Jun 14, 2018

This was solved in #3632

@stsewd stsewd closed this as completed Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Good for new contributors Improvement Minor improvement to code Sprintable Small enough to sprint on
Projects
None yet
Development

No branches or pull requests

4 participants