New subproject admin page #2957
Conversation
The privacy app was a strange mixture of various application models managers, querysets, and syncers. Instead, logic is moved to where we should be using it, inside the other applications
This replaces the list of text with a table that is more navigable and also replaces the create form with a dropdown form of the projects you can add. This list of projects is limited to projects you are the admin of, and which have not been added as a sub or super project anywhere else. This depends on #2954 and others.
agjohnson
added
the
PR: work in progress
agjohnson
added
PR: ready for review
and removed
PR: work in progress
Conflicts: readthedocs/projects/forms.py
|
This should be ready for review now, I've merged in master. |
There was a problem hiding this comment.
This looks good. I'd like to see additions to the projects detail page that also show that it's a subproject, because that is currently confusing. I believe I hacked in a basic version of it in the header, but we could definitely be doing more to include the info about super/sub projects on detail pages, to make this stuff more understandable for users.
readthedocs/projects/forms.py
Outdated
|
|
||
| def __init__(self, *args, **kwargs): | ||
| self.project = kwargs.pop('project', None) | ||
| self.user = kwargs.pop('user', None) |
There was a problem hiding this comment.
Should we be checking for the existence of these variables here? Seems like it would throw errors accessing None later on.
| class ProjectRelationshipDelete(ProjectRelationshipMixin, DeleteView): | ||
|
|
||
| def get(self, request, *args, **kwargs): | ||
| return self.http_method_not_allowed(request, *args, **kwargs) |
There was a problem hiding this comment.
Is this not already defined on the DeleteView? Seems odd it wouldn't disallow GET's already.
There was a problem hiding this comment.
Nope, get on deleteview displays a form that asks for confirmation. I'd like to settle on a deleteview override and never use confirmation forms, but we do use them in some places currently.
This replaces the list of text with a table that is more navigable and also
replaces the create form with a dropdown form of the projects you can add.
This list of projects is limited to projects you are the admin of, and
which have not been added as a sub or super project anywhere else.
This depends on #2954 and others.