Remove privacy app #2954
Merged
Remove privacy app #2954
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The privacy app was a strange mixture of various application models managers, querysets, and syncers. Instead, logic is moved to where we should be using it, inside the other applications
agjohnson
added
the
PR: work in progress
agjohnson
added
PR: ready for review
and removed
PR: work in progress
agjohnson
added a commit
that referenced
this pull request
Jun 20, 2017
This replaces the list of text with a table that is more navigable and also replaces the create form with a dropdown form of the projects you can add. This list of projects is limited to projects you are the admin of, and which have not been added as a sub or super project anywhere else. This depends on #2954 and others.
| @@ -1,18 +1,22 @@ | |||
| """Classes allowing copying files around. | |||
| """Classes to copy files between build and web servers | |||
There was a problem hiding this comment.
Believe this file rename will need to change in our prod settings too.
There was a problem hiding this comment.
Yup! I got a PR on ops, but it needs to be updated as it's conflicting with the other PR you opened around Syncers
agjohnson
added a commit
that referenced
this pull request
Jun 22, 2017
* Remove privacy app The privacy app was a strange mixture of various application models managers, querysets, and syncers. Instead, logic is moved to where we should be using it, inside the other applications * New subproject admin page This replaces the list of text with a table that is more navigable and also replaces the create form with a dropdown form of the projects you can add. This list of projects is limited to projects you are the admin of, and which have not been added as a sub or super project anywhere else. This depends on #2954 and others. * Lint fixes * Require arguments to project form
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The privacy app was a strange mixture of various application models managers,
querysets, and syncers. Instead, logic is moved to where we should be using it,
inside the other applications