Skip to content

Convert managers to querysets, resolves #2617 #2896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 24, 2017

Conversation

fmoor
Copy link
Contributor

@fmoor fmoor commented May 23, 2017

No description provided.

Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but noted rebasing the documentation change out on the mercurial PR.

docs/install.rst Outdated
.. note::

Some unit tests depend on Hg (mercurial).
Be sure that Hg is `installed <https://www.mercurial-scm.org/wiki/Download>`_ if you want to see all the tests pass.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Similar to other PRs, i'd like to instead fix tests with mercurial if possible. Could this be rebased out?

@fmoor fmoor force-pushed the feature/managers_to_querysets branch from 5b8dacf to 67a32d3 Compare May 24, 2017 20:49
@fmoor
Copy link
Contributor Author

fmoor commented May 24, 2017

@agjohnson rebasing should be done now

@agjohnson agjohnson merged commit 64854e4 into readthedocs:master May 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants