Skip to content

Convert managers to querysets #2617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
agjohnson opened this issue Jan 27, 2017 · 0 comments
Closed

Convert managers to querysets #2617

agjohnson opened this issue Jan 27, 2017 · 0 comments
Labels
Good First Issue Good for new contributors Sprintable Small enough to sprint on
Milestone
Cleanup

Comments

@agjohnson
Copy link
Contributor

We are currently using custom managers on build and project models, but this results in querysets that aren't chainable. These managers can be replaced with a pattern similar to readthedocs.privacy.backend.VersionQuerySetBase and if necessary, a complimentary models.Manager subclass as well -- if create methods are required, etc.

Ref #2611
@agjohnson agjohnson added Good First Issue Good for new contributors Sprintable Small enough to sprint on labels Jan 27, 2017
@agjohnson agjohnson added this to the Cleanup milestone Jan 27, 2017
fmoor added a commit to fmoor/readthedocs.org that referenced this issue May 23, 2017
@fmoor
Convert managers to querysets, resolves readthedocs#2617
196fa9f
fmoor added a commit to fmoor/readthedocs.org that referenced this issue May 24, 2017
@fmoor
Convert managers to querysets, resolves readthedocs#2617
67a32d3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Good for new contributors Sprintable Small enough to sprint on
Projects
None yet
Milestone
Cleanup
Development

No branches or pull requests
1 participant
@agjohnson