This merges all the bugfix PR's I had into one. #2754
Conversation
This stops a large number of requests from old pages. It depends on v1 of our API and it broken.
This fixes errors on search indexing of files that don't fit the format. This was triggering on eg. `searchindex.json` in the JSON builders
We should probably upgrade to Python 3 to remove all these issues, but this at least will fix this one.
This errors in all the cases I tested (202, 400), so I'm not sure what the original intent was. This gives users 500's on project import if GH import fails, so probably a pretty high priority to fix.
ericholscher
added
the
PR: work in progress
ericholscher
added
PR: ready for review
and removed
PR: work in progress
ericholscher
force-pushed
the
bugfix-bundle
branch
from
799ef27 to
2e937a6
Compare
| @@ -214,5 +214,5 @@ def setup_webhook(self, project): | |||
| log.error('Bitbucket webhook creation failed for project: %s', | |||
| project) | |||
| log.debug('Bitbucket webhook creation failure response: %s', | |||
| dict(resp)) | |||
| resp.content) | |||
There was a problem hiding this comment.
resp.json() is more correct. Also, feel free to drop this, I have a fix in my branch.
There was a problem hiding this comment.
That only works for JSON content, and most of the issues here are the responses aren't valid JSON.
| @@ -205,7 +205,7 @@ def setup_webhook(self, project): | |||
| log.error('GitHub webhook creation failed for project: %s', | |||
| project) | |||
| log.debug('GitHub webhook creation failure response: %s', | |||
| dict(resp)) | |||
| resp.content) | |||
| promoted_version.slug in added_versions): | ||
| promoted_version.active = True | ||
| promoted_version.save() | ||
| trigger_build(project=project, version=promoted_version) |
There was a problem hiding this comment.
This removed get_stable_version call, what was the problem there? Any side effects on this?
There was a problem hiding this comment.
It wasn't used, so I figured not, it seemed like a weird thing to have side effects, but didn't check.
There was a problem hiding this comment.
No side effects, just dead code.
media/javascript/rtd.js
Outdated
| @@ -67,7 +67,7 @@ | |||
| } | |||
| ); | |||
|
|
|||
| checkVersion(slug, version); | |||
| // checkVersion(slug, version); | |||
There was a problem hiding this comment.
Might be a good spot for a comment on why this is disabled
|
Gonna merge this and get it deployed to hopefully reduce errors over the weekend -- the resp changes shouldn't cause bad conflicts, so will include those in, since it's blowing up project import sometimes atm. |
Fix errors caused by calling
dicton a Response.This errors in all the cases I tested (202, 400), so I'm not sure what the
original intent was. This gives users 500's on project import if GH import
fails, so probably a pretty high priority to fix.
--
Fix CORS requests not having ORIGIN
--
Fix unicode handling in resolver
We should probably upgrade to Python 3 to remove all these issues, but this
at least will fix this one.
--
Validate the JSON file we're trying to load works.
This fixes errors on search indexing of files that don't fit the format.
This was triggering on eg.
searchindex.jsonin the JSON builders--
Remove the call to our API from old projects.
This stops a large number of requests from old pages. It depends on v1 of
our API and it broken.