Add test for version syncing unicode

Author: ericholscher

readthedocs/restapi/views/model_views.py

@@ -132,27 +132,23 @@ def sync_versions(self, request, **kwargs):
             log.exception("Sync Versions Error: %s" % e.message)
             return Response({'error': e.message}, status=status.HTTP_400_BAD_REQUEST)
 
-        try:
-            old_stable = project.get_stable_version()
-            promoted_version = project.update_stable_version()
-            if promoted_version:
-                new_stable = project.get_stable_version()
-                log.info(
-                    "Triggering new stable build: {project}:{version}".format(
-                        project=project.slug,
-                        version=new_stable.identifier))
-                trigger_build(project=project, version=new_stable)
-
-                # Marking the tag that is considered the new stable version as
-                # active and building it if it was just added.
-                if (
-                        activate_new_stable and
-                        promoted_version.slug in added_versions):
-                    promoted_version.active = True
-                    promoted_version.save()
-                    trigger_build(project=project, version=promoted_version)
-        except:
-            log.exception("Stable Version Failure", exc_info=True)
+        promoted_version = project.update_stable_version()
+        if promoted_version:
+            new_stable = project.get_stable_version()
+            log.info(
+                "Triggering new stable build: {project}:{version}".format(
+                    project=project.slug,
+                    version=new_stable.identifier))
+            trigger_build(project=project, version=new_stable)
+
+            # Marking the tag that is considered the new stable version as
+            # active and building it if it was just added.
+            if (
+                    activate_new_stable and
+                    promoted_version.slug in added_versions):
+                promoted_version.active = True
+                promoted_version.save()
+                trigger_build(project=project, version=promoted_version)
 
         return Response({
             'added_versions': added_versions,

readthedocs/rtd_tests/tests/test_sync_versions.py

@@ -1,3 +1,5 @@
+# -*- coding: utf-8 -*-
+
 import json
 
 from django.test import TestCase
@@ -344,3 +346,18 @@ def test_update_inactive_stable_version(self):
         version_stable = Version.objects.get(slug=STABLE)
         self.assertFalse(version_stable.active)
         self.assertEqual(version_stable.identifier, '1.0.0')
+
+    def test_unicode(self):
+        version_post_data = {
+            'branches': [],
+            'tags': [
+                {'identifier': 'foo-£', 'verbose_name': 'foo-£'},
+            ]
+        }
+
+        resp = self.client.post(
+            '/api/v2/project/%s/sync_versions/' % self.pip.pk,
+            data=json.dumps(version_post_data),
+            content_type='application/json',
+        )
+        self.assertEqual(resp.status_code, 200)