Skip to content

Upgrade django filter #2501

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Nov 28, 2016
Merged

Upgrade django filter #2501

merged 4 commits into from
Nov 28, 2016

Conversation

rpkilby
Copy link
Contributor

@rpkilby rpkilby commented Nov 14, 2016

Hi all, this should (hopefully) resolve all of the django-filter issues, migrating you to the upcoming 1.0 release.

should fix #2490, fix #2495, fix #2498, supersede/resolve #2499

@benjaoming
Copy link
Contributor

Agreed, RTD maintainers can skip #2499 in this case - or in case they want to wait for the final django-filter 1.0 release, they could leave this PR until the release day.

@rpkilby how ready do you estimate the current django-filter develop branch to be? Or when would you guess it's shipping?

@rpkilby
Copy link
Contributor Author

rpkilby commented Nov 14, 2016

1.0 is pretty much ready for release. Unless any new bugs are found, the only thing left to do is release it to pypi.

@benjaoming
Copy link
Contributor

Cool, in that case I think we should wait for 1.0 on PyPi, and then add django-filters>=1.0,<1.1 to the requirements file to get rid of the old unpinned git dependency.

@ericholscher
Copy link
Member

I'll hold off on this, and ship it once the 1.0 release is on PyPI.

@agjohnson agjohnson added the Status: blocked Issue is blocked on another issue label Nov 16, 2016
@rpkilby
Copy link
Contributor Author

rpkilby commented Nov 23, 2016

Hi @ericholscher - django-filter 1.0.0 has officially been released. I've updated the pip reqs to lock it at 1.0

@ericholscher ericholscher merged commit d7abdd6 into readthedocs:master Nov 28, 2016
@ericholscher
Copy link
Member

Thanks for the update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: blocked Issue is blocked on another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update django-filter to 1.0 'VersionSlugFilter' object is not iterable Broken/unpegged django-filter dependency
4 participants