Skip to content

Update django-filter to 1.0 #2498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
benjaoming opened this issue Nov 14, 2016 · 3 comments · Fixed by #2501
Closed

Update django-filter to 1.0 #2498

benjaoming opened this issue Nov 14, 2016 · 3 comments · Fixed by #2501

Comments

@benjaoming
Copy link
Contributor

Details

Sorry for deleting the issue template: This is about technical debt :) It may not be immediately critical, but the advice from the author of django-filter is that it's worth it.

django-filter 1.0 has changes that are backwards incompatible. The release notes are here:

http://django-filter.readthedocs.io/en/latest/migration.html

It means, amongst other this, that all where Filter object instances are iterated on, we have to add the .qs method.

@rpkilby
Copy link
Contributor

rpkilby commented Nov 14, 2016

Hi @benjaoming - I'm partly to blame for the API breakage 😅. Feel free to ping me if you have any questions about the changes.

@benjaoming
Copy link
Contributor Author

@rpkilby - thanks! it's a major version bump and with a nice migration guide so it's all in good order I guess :) I've opened the issue, hoping that someone who knows the codebase well is going to do the refactor.. I'm shying away here.

@rpkilby
Copy link
Contributor

rpkilby commented Nov 14, 2016

Hi @benjaoming - went ahead and took a stab at it (see #2501). Not familiar with the RTD source, so I may have missed something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants