Skip to content

Lint project code #1580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 26, 2015
Merged

Lint project code #1580

merged 1 commit into from
Aug 26, 2015

Conversation

agjohnson
Copy link
Contributor

This lints project code to medium strictness and conforms to pep257. This uses
some additional options to reduce false errors, which I'll add in a separate PR.
This should pass our normal linting without a problem, except the minor change
to unused variable name regex.

This adds __ to the default list of _ and dummy* for unused arguments. I
prefer the default of _, but that overlaps with the translation helper _().
I'd be happy to rethink a scheme here.

Fixes #1472, refs #1474

@agjohnson
Copy link
Contributor Author

Currently this is failing due to this:
https://github.com/rtfd/readthedocs.org/blob/lint-project/readthedocs/projects/search_indexes.py#L84-L85

html_to_index is never defined, I haven't dug into history to see what that was supposed to be yet. I'm not entirely sure what this method is supposed to be doing. @ericholscher thoughts here?

@ericholscher
Copy link
Member

Looks like it was in the last commit --
ea05994
-- not sure what exactly it's meant to be.

On Fri, Aug 21, 2015 at 4:25 PM, Anthony [email protected] wrote:

Currently this is failing due to this:

https://github.com/rtfd/readthedocs.org/blob/lint-project/readthedocs/projects/search_indexes.py#L84-L85

html_to_index is never defined, I haven't dug into history to see what
that was supposed to be yet. I'm not entirely sure what this method is
supposed to be doing. @ericholscher https://github.com/ericholscher
thoughts here?


Reply to this email directly or view it on GitHub
#1580 (comment)
.

Eric Holscher
Maker of the internet residing in Portland, Oregon
http://ericholscher.com

This lints project code to medium strictness and conforms to pep257. This uses
some additional options to reduce false errors, which I'll add in a separate PR.
This should pass our normal linting without a problem, except the minor change
to unused variable name regex.

This adds `__` to the default list of `_` and `dummy*` for unused arguments. I
prefer the default of `_`, but that overlaps with the translation helper `_()`.
I'd be happy to rethink a scheme here.
ericholscher added a commit that referenced this pull request Aug 26, 2015
@ericholscher ericholscher merged commit 3747975 into master Aug 26, 2015
@stsewd stsewd deleted the lint-project branch August 15, 2018 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants