Skip to content

basic attribute not used on trigger_build #3888

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
humitos opened this issue Apr 2, 2018 · 2 comments
Closed

basic attribute not used on trigger_build #3888

humitos opened this issue Apr 2, 2018 · 2 comments
Labels
Improvement Minor improvement to code
Milestone
Cleanup

Comments

@humitos
Copy link
Member

humitos commented Apr 2, 2018

While debugging a unrelated different thing, I found that the attribute basic is not used at all when calling trigger_build.

https://github.com/rtfd/readthedocs.org/blob/7aa6f4d41acbc8b35b7f2b891496ae0ded9f68f8/readthedocs/core/utils/__init__.py#L101

I don't know what this was useful for (I didn't check the git log yet) but it's something that we can probably remove for cleanness.
@humitos humitos added the Improvement Minor improvement to code label Apr 2, 2018
@humitos humitos added this to the Cleanup milestone Apr 2, 2018
@stsewd
Copy link
Member

stsewd commented May 17, 2018

This was added on 4be6876

I'll try to see why

@stsewd
Copy link
Member

stsewd commented May 17, 2018

This was removed on https://github.com/rtfd/readthedocs.org/pull/1580/files#diff-b9399e1d3499066c5564f98a620e8881L95 in #1580

Looks like this was never used 🤔

@humitos humitos mentioned this issue Jun 11, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Improvement Minor improvement to code
Projects
None yet
Milestone
Cleanup
Development

No branches or pull requests
2 participants
@humitos @stsewd