Add per-command tracking to API out output detail page #1563
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other than the inline comments: awesome! I haven't tried this locally, only looked at your screenshot. Can the output be scrolled horizontally? |
17 tasks
ericholscher
added
the
PR: work in progress
|
And yeah, command/output elements are all independently horizontally scrollable |
agjohnson
added
PR: ready for review
and removed
PR: work in progress
|
Looks good to me. 🚢 |
This adds a build manager for the Build model, for moving everything to the v2 API
This also drops unused API endpoints and serializers
Also makes command failures a warning class exception, so they are not reported as top level failures. Adds time tracking to start and end time to command execution.
agjohnson
force-pushed
the
build-ux-refactor
branch
from
d31e072 to
5a44915
Compare
agjohnson
added a commit
that referenced
this pull request
Aug 19, 2015
Add per-command tracking to API out output detail page
|
The UI really looks good in production :) I noticed that the builds for the tickets #1028 #1572 do not contain any output: However, the users were able to provide a error message (stating something about wrong parameters to init). I wonder if the informational output got less after the deploy of this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry for another undigestable refactor, but no way to do this incrementally.
This adds per-command tracking inside build environments and on the build
detail page. Instead of lumping build output together, this starts to break out
output and errors into logical chunks that will be easier to understand by end
users. The front end pieces make use of KnockoutJS for data binding objects to
the DOM. It performs an ajax call to the build api to return updates on the
build object and commands that are attached to the build object.
The API has the following changes:
read-only access