-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
Condiontally homepage redirect based on domain and logged in status #12147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work? I mean, how do we check if the user is logged in under
app.readthedocs.org
if they are hittingreadthedocs.org
? cc @agjohnsonThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, with no
web
instances anymore, and only instances set up with a production domain ofapp.readthedocs.org
, those instances are likely going to handle requests forreadthedocs.org
as a project custom domain through proxito.So I'm guessing this approach won't work, but I'd still test this to make sure.
But we probably needed the
web
ASG, with instances listening for the domainreadthedocs.org
, to support doing anything dynamic with requests to the old domain.If this does work, any
redirect()
probably should have an explicit domain.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
app.readthedocs.org
andreadthedocs.org
will hitweb-ext-theme
proxito instances. I understand that to check if the user is logged in or not, the settingSESSION_COOKIE_DOMAIN
andSESSION_COOKIE_NAME
are used and on both requests they will have the same values -- so, I think this should work as expected.