Condiontally homepage redirect based on domain and logged in status #12147
Conversation
| if request.user.is_authenticated: | ||
| return redirect("projects_dashboard") |
There was a problem hiding this comment.
Does this work? I mean, how do we check if the user is logged in under app.readthedocs.org if they are hitting readthedocs.org? cc @agjohnson
There was a problem hiding this comment.
Well, with no web instances anymore, and only instances set up with a production domain of app.readthedocs.org, those instances are likely going to handle requests for readthedocs.org as a project custom domain through proxito.
So I'm guessing this approach won't work, but I'd still test this to make sure.
But we probably needed the web ASG, with instances listening for the domain readthedocs.org, to support doing anything dynamic with requests to the old domain.
If this does work, any redirect() probably should have an explicit domain.
There was a problem hiding this comment.
app.readthedocs.org and readthedocs.org will hit web-ext-theme proxito instances. I understand that to check if the user is logged in or not, the setting SESSION_COOKIE_DOMAIN and SESSION_COOKIE_NAME are used and on both requests they will have the same values -- so, I think this should work as expected.
|
I'm going to merge this PR now so we can deploy it today. @agjohnson I would still appreciate any feedback you may have here. It won't have any effect without changing the CF redirect, tho. We can test it that way 👍🏼 |
|
I didn't have any other notes here, the change looked good besides my question on request flow |
Related https://github.com/readthedocs/readthedocs-ops/pull/1626
Closes https://github.com/readthedocs/readthedocs-ops/issues/1602