-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New dashboard: remove legacy HTML templates #12100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: humitos/remove-exttheme-var
Are you sure you want to change the base?
Conversation
Try this plyugin to find out templates that are not used from this repository and can be removed from here. Related #12086
django-coverage-plugin
Looks like there are some files that we should ignore https://app.codecov.io/gh/readthedocs/readthedocs.org/pull/12100/tree |
from this list https://app.codecov.io/gh/readthedocs/readthedocs.org/pull/12100/tree?search=.html&displayType=list it seems we are using only the first 15 .html files. |
I pushed another commit that removes all the HTML templates that are not required to run the tests. I also explore a few pages in .org and .com after removing these templates and everything worked fine. I'm splitting the removal of these templates into a separate PR so we can merge #12091 first and after making that work, we can merge this one. |
django-coverage-plugin
I'm still not sure the testing method used to determine template usage is very accurate here. I'm pretty sure there are other templates that are coming through, so I'm a little worried we're missing these with this test method. I have not moved the email templates as these are not part of the dashboard. They'd be better off in application template paths probably. |
This PR install
django_coverage_plugin
to try finding templates that are sill used/required.Besides, it deletes all the old templates while keeping the tests passing. There are at least 2 templates,
readthedocs/organizations/templates/organizations/base_team.html
andreadthedocs/templates/projects/email/build_failed.html
that need to be moved to ext-theme. These can't be removed yet since they are still used.Related #12086
Closes #12105