New dashboard: remove legacy dashboard #12091
Conversation
It was deleted with `BuildTriggerMixin`, so this commit recovers it.
We deleted that endpoint and it's only done via the APIv3 now.
| @@ -213,71 +203,6 @@ def test_build_list_includes_external_versions(self): | |||
| self.assertEqual(response.status_code, 200) | |||
| self.assertIn(external_version_build, response.context["build_qs"]) | |||
|
|
|||
| @mock.patch("readthedocs.projects.tasks.builds.update_docs_task") | |||
| @mock.patch("readthedocs.core.utils.cancel_build") | |||
| def test_rebuild_specific_commit(self, mock_update_docs_task, mock_cancel_build): | |||
There was a problem hiding this comment.
All these deleted tests don't look to be specific to the old theme?
There was a problem hiding this comment.
These tests are for the POST request done to the dashboard to rebuild. That view was deleted and is now done via APIv3. That's why I deleted these tests as well.
| if ext_theme: | ||
| apps.append("readthedocsext.theme") |
There was a problem hiding this comment.
Should probably always include this, as without exttheme the app would no longer work
There was a problem hiding this comment.
I tried that, but I had to add this conditional because there are some scenarios where exttheme is not present: embed testings, for example.
We can work on polishing that in another PR if we want; but I didn't want to block this work due to that.
Co-authored-by: Santos Gallegos <[email protected]>
|
I did a test for this at https://readthedocs.slack.com/archives/G81T0N8S3/p1745509009820219 and it worked as expected. I think we are ready to merge this PR. We can fix any edge case that I may be missing as we go. |
There was a problem hiding this comment.
This looks great 👍
The only thing that makes me a little uneasy is the static file removal. I'm not certain about some of those files. I know we shouldn't be referencing them with any projects built rather recently, but I do worry they are referenced by builds that we aren't considering.
So I might suggest we feed some of the important files in that list into Cloudflare to see if we have any volume of hits on files from referred sources that seem legitimate.
| You are currently using our legacy dashboard, which will be retired on <time datetime="2025-03-11">March 11th, 2025</time>. | ||
| You should <a href="//{{ SWITCH_PRODUCTION_DOMAIN }}{% url "account_login" %}">switch to our new dashboard</a> before then. | ||
| {% endif %} | ||
| We are beginning to direct users to our new dashboard as we work to retire our legacy dashboard. |
There was a problem hiding this comment.
We should make sure to remove this and the onboarding announcement for the new dashboard soon.
| # TODO remove this with RTD_EXT_THEME_ENABLED | ||
| # This is going to try hard to show the new dashboard announcement. | ||
| # We can't yet back down to another announcement as we don't have | ||
| # the ability to evaluate local storage. Until we add the ability to | ||
| # dynamically change the announcement, this is going to be the only | ||
| # announcement shown. | ||
| if True: # pylint: disable=using-constant-test | ||
| template_name = "new-dashboard.html" |
There was a problem hiding this comment.
Ahh yes this is the onboarding announcement I was describing above 👍
testchecks #12085Related https://github.com/readthedocs/readthedocs-ops/issues/1600