Skip to content

Small improvements on PR previews handling #12061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Small improvements on PR previews handling #12061

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f4adafb
Small improvements on PR previews handling
stsewd Mar 19, 2025
0bb9888
Format
stsewd Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions readthedocs/core/views/hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,7 @@ def get_or_create_external_version(project, version_data):
external_version.identifier = version_data.commit
# If the PR was previously closed it was marked as closed
external_version.state = EXTERNAL_VERSION_STATE_OPEN
external_version.active = True
external_version.save()
log.info(
"External version updated.",
Expand All @@ -172,12 +173,7 @@ def close_external_version(project, version_data):
:rtype: str
"""
external_version = (
project.versions(manager=EXTERNAL)
.filter(
verbose_name=version_data.id,
identifier=version_data.commit,
)
.first()
project.versions(manager=EXTERNAL).filter(verbose_name=version_data.id).first()
)

if external_version:
Expand Down