Skip to content

Small improvements on PR previews handling #12061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 24, 2025
Merged

Small improvements on PR previews handling #12061

merged 2 commits into from
Mar 24, 2025

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Mar 19, 2025

  • When a PR preview is re-opened, make sure to reset its status as active
  • When closing a PR we don't need to take into consideration the commit, we act based on the ID only.

Extracted from #11942

@stsewd stsewd requested a review from a team as a code owner March 19, 2025 22:31
@stsewd stsewd requested a review from humitos March 19, 2025 22:31
@stsewd stsewd requested a review from ericholscher March 24, 2025 21:01
@stsewd stsewd merged commit 29ab345 into main Mar 24, 2025
8 checks passed
@stsewd stsewd deleted the improvements-version-sync branch March 24, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericholscher ericholscher ericholscher approved these changes

@humitos humitos Awaiting requested review from humitos humitos is a code owner automatically assigned from readthedocs/backend

Assignees

@stsewd stsewd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @ericholscher