Skip to content

API v3: don't inherit from flex fields when no needed #11745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 6, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions readthedocs/api/v3/serializers.py
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
from readthedocs.redirects.validators import validate_redirect


class UserSerializer(FlexFieldsModelSerializer):
class UserSerializer(serializers.ModelSerializer):
class Meta:
model = User
fields = [
Expand Down Expand Up @@ -331,7 +331,7 @@ def get_documentation(self, obj):
)


class VersionSerializer(FlexFieldsModelSerializer):
class VersionSerializer(serializers.ModelSerializer):
aliases = serializers.SerializerMethodField()
ref = serializers.CharField()
downloads = serializers.SerializerMethodField()
Expand Down Expand Up @@ -586,7 +586,7 @@ def get_notifications(self, obj):
return self._absolute_url(path)


class ProjectCreateSerializerBase(TaggitSerializer, FlexFieldsModelSerializer):
class ProjectCreateSerializerBase(TaggitSerializer, serializers.ModelSerializer):

"""Serializer used to Import a Project."""

Expand Down Expand Up @@ -679,7 +679,7 @@ class ProjectCreateSerializer(SettingsOverrideObject):
_default_class = ProjectCreateSerializerBase


class ProjectUpdateSerializerBase(TaggitSerializer, FlexFieldsModelSerializer):
class ProjectUpdateSerializerBase(TaggitSerializer, serializers.ModelSerializer):

"""Serializer used to modify a Project once imported."""

Expand Down Expand Up @@ -936,7 +936,7 @@ class Meta(ProjectSerializer.Meta):
]


class SubprojectSerializer(FlexFieldsModelSerializer):
class SubprojectSerializer(serializers.ModelSerializer):

"""Serializer to render a subproject (``ProjectRelationship``)."""

Expand All @@ -952,7 +952,7 @@ class Meta:
]


class SubprojectDestroySerializer(FlexFieldsModelSerializer):
class SubprojectDestroySerializer(serializers.ModelSerializer):

"""Serializer used to remove a subproject relationship to a Project."""

Expand Down