Skip to content

API v3: don't inherit from flex fields when no needed #11745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2024
Merged

API v3: don't inherit from flex fields when no needed #11745

merged 1 commit into from
Nov 6, 2024

Conversation

stsewd
Copy link
Member

@stsewd stsewd commented Nov 5, 2024

No description provided.

@stsewd stsewd requested a review from a team as a code owner November 5, 2024 16:45
@stsewd stsewd requested a review from humitos November 5, 2024 16:45
humitos
humitos approved these changes Nov 6, 2024
View reviewed changes
Copy link
Member

@humitos humitos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. FlexSerializer was used to have ?expand= available?

@stsewd
Copy link
Member Author

stsewd commented Nov 6, 2024

Looks good. FlexSerializer was used to have ?expand= available?

yes

@stsewd stsewd merged commit 0e4a305 into main Nov 6, 2024
8 checks passed
@stsewd stsewd deleted the inherit-from-modelserializer branch November 6, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@humitos humitos humitos approved these changes

Assignees

@stsewd stsewd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stsewd @humitos