Addons: always sort versions in descending order #11691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were mixing ascending and descending when listing the versions, we now always sort in descending order. Even if the version fails to parse, we still sort it in descending order as fallback. Closes #11689
stsewd
commented
Oct 16, 2024
Comment on lines
-43
to
+44
| "1.1", | ||
| "1.1.0", | ||
| "1.1", |
There was a problem hiding this comment.
Since 1.1 and 1.1.0 are the same version, it falls back to sort them alphabetically in descending order now.
There was a problem hiding this comment.
This should probably be a code comment :)
There was a problem hiding this comment.
I mean, all tests are like this now.
There was a problem hiding this comment.
There is a lot of comments that are incorrect after this change: Invalid versions are at the end sorted alphabetically.
There was a problem hiding this comment.
They are still sorted alphabetically, but in descending order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were mixing ascending and descending when listing the versions, we now always sort in descending order. Even if the version fails to parse, we still sort it in descending order as fallback.
Closes #11689