Skip to content

Addons: allow choosing ascending or descending order when listing versions #11689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stsewd opened this issue Oct 15, 2024 · 3 comments · Fixed by #11691
Closed

Addons: allow choosing ascending or descending order when listing versions #11689

stsewd opened this issue Oct 15, 2024 · 3 comments · Fixed by #11691
Labels
Needed: design decision A core team decision is required

Comments

@stsewd
Copy link
Member

stsewd commented Oct 15, 2024

What's the problem this feature will solve?

Right now we have a mix of ascending and descending order, but we should let users choose, or maybe just always sort by descending order, since users will probably want to see the latest versions first.

Describe the solution you'd like

Another option for the version listing

Alternative solutions

Always use descending order
@stsewd stsewd added the Needed: design decision A core team decision is required label Oct 15, 2024
@ericholscher
Copy link
Member

Yea, I think we likely want descending order as the default.

@stsewd
Copy link
Member Author

stsewd commented Oct 15, 2024

Yea, I think we likely want descending order as the default.

Do you mean like that's the only option? Or do we still want to give users a choice?

@ericholscher
Copy link
Member

I'm also OK giving them a choice, but seems pretty fiddly. Not sure what user would want it starting with the oldest version? 🤷

stsewd added a commit that referenced this issue Oct 16, 2024
@stsewd
Addons: always sort versions in descending order
1a41a4d 
We were mixing ascending and descending when listing the versions,
we now always sort in descending order. Even if the version
fails to parse, we still sort it in descending order as fallback.

Closes #11689
@stsewd stsewd mentioned this issue Oct 16, 2024
Merged
@stsewd stsewd closed this as completed in 9451d9c Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Needed: design decision A core team decision is required
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Addons: always sort versions in descending order readthedocs/readthedocs.org
2 participants
@ericholscher @stsewd