Tests: run tests with the ext-theme #11383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stsewd
force-pushed
the
run-tests-with-ext-theme
branch
from
ce4a15a to
01ef066
Compare
|
Back to draft, forgot to run proxito tests... |
|
Expect some potential issues with proxito, as the templates have not been used on that instance yet. |
stsewd
commented
Jun 13, 2024
Comment on lines
-34
to
-38
| # Patch URLs that call the `fast_404` view directly. | ||
| for pattern in urlpatterns: | ||
| if getattr(pattern, "name", None) == "docs_detail_directory_indexing": | ||
| pattern.callback = handler404 | ||
| break |
There was a problem hiding this comment.
We don't have a URL named docs_detail_directory_indexing, so not sure what this was about.
agjohnson
reviewed
Jun 19, 2024
ericholscher
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
readthedocsextto check if that app was available, but since the new theme shares that same namespace, we need to check for something else more specific to our ext app.ref #11299