Skip to content

Tests: start running tests with ext-theme and new templates enabled #11299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
agjohnson opened this issue Apr 23, 2024 · 1 comment
Closed

Tests: start running tests with ext-theme and new templates enabled #11299

agjohnson opened this issue Apr 23, 2024 · 1 comment
Assignees
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code

Comments

@agjohnson
Copy link
Contributor

agjohnson commented Apr 23, 2024

We are getting close to the point where we should be running tests against ext-theme and the new templates, as these will inflict some tests failures where tests are looking for specific response or interacting with forms, and also where we are isolating new behavior in views with settings.RTD_EXT_THEME_ENABLED

For a first pass, we can start by marking any tests a xfail if they feel like they are primarily for the legacy dashboard, instead of repairing all the tests.

@agjohnson agjohnson added Improvement Minor improvement to code Accepted Accepted issue on our roadmap labels Apr 23, 2024
@github-project-automation github-project-automation bot moved this to Planned in 📍Roadmap Apr 23, 2024
@stsewd stsewd moved this from Planned to In progress in 📍Roadmap Jun 4, 2024
@stsewd stsewd moved this from In progress to Needs review in 📍Roadmap Jun 20, 2024
@stsewd stsewd moved this from Needs review to In progress in 📍Roadmap Jun 20, 2024
@stsewd
Copy link
Member

stsewd commented Jul 23, 2024

We are running test with ext-theme on .org, we are only missing .com (https://github.com/readthedocs/readthedocs-corporate/pull/1807). For that we just need readthedocs/ext-theme#393.

@stsewd stsewd closed this as completed Sep 3, 2024
@stsewd stsewd closed this as completed Sep 3, 2024
@github-project-automation github-project-automation bot moved this from Needs review to Done in 📍Roadmap Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted Accepted issue on our roadmap Improvement Minor improvement to code
Projects
Archived in project
Development

No branches or pull requests

2 participants