Notification: fix choices rendering for INVALID_CHOICE
#11190
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While taking a look at #11189 I found that the rendering was broken. I found the `with` + `yield` pattern pretty complex (I have a note about this in the code) and it seems that complexity is confusing enough to make this hard to dealt with. Anyways, I fixed the problem for now and I added a test case. We can come back to refactoring this in the future with more time.
stsewd
approved these changes
Mar 5, 2024
Co-authored-by: Santos Gallegos <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While taking a look at #11189 I found that the rendering was broken. I found the
with+yieldpattern pretty complex (I have a note about this in the code) and it seems that complexity is confusing enough to make this hard to dealt with.Anyways, I fixed the problem for now and I added a test case. We can come back to refactoring this in the future with more time.
This PR solves this problem where the choices are not shown in between brackets.