Skip to content

Build: add support for Go 1.22 #11189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
simondeziel opened this issue Mar 5, 2024 · 3 comments
Closed

Build: add support for Go 1.22 #11189

simondeziel opened this issue Mar 5, 2024 · 3 comments
Labels
Needed: more information A reply from issue author is required

Comments

@simondeziel
Copy link

What's the problem this feature will solve?

Some projects require Go 1.22 to build.

Describe the solution you'd like

Go 1.22 is the current latest stable release and RTD should support it.

Alternative solutions

N/A

Additional context

https://go.dev/doc/devel/release

@humitos
Copy link
Member

humitos commented Mar 5, 2024

Hi @simondeziel! Thanks for opening this issue. Would you mind posting the URL of the projects requiring Go 1.22? Thanks.

@simondeziel
Copy link
Author

Hey @humitos, sure it's the LXD project where we are trying to switch to Go 1.22 for every bits canonical/lxd#13042

humitos added a commit that referenced this issue Mar 5, 2024
While taking a look at #11189 I found that the rendering was broken.
I found the `with` + `yield` pattern pretty complex (I have a note about this in
the code) and it seems that complexity is confusing enough to make this hard to
dealt with.

Anyways, I fixed the problem for now and I added a test case. We can come back
to refactoring this in the future with more time.
humitos added a commit that referenced this issue Mar 6, 2024
* Notification: fix `choices` rendering for `INVALID_CHOICE`

While taking a look at #11189 I found that the rendering was broken.
I found the `with` + `yield` pattern pretty complex (I have a note about this in
the code) and it seems that complexity is confusing enough to make this hard to
dealt with.

Anyways, I fixed the problem for now and I added a test case. We can come back
to refactoring this in the future with more time.

* Update readthedocs/config/config.py

Co-authored-by: Santos Gallegos <[email protected]>

---------

Co-authored-by: Santos Gallegos <[email protected]>
@humitos
Copy link
Member

humitos commented Jun 4, 2024

Closing in favor of a more generic issue that will include this work as well: #11350

@humitos humitos closed this as not planned Won't fix, can't repro, duplicate, stale Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needed: more information A reply from issue author is required
Projects
None yet
Development

No branches or pull requests

2 participants