Some fixes for notifications #11094
Merged
Some fixes for notifications #11094
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a few fixes and small restructuring to the notification/message classes. - Centralize message lookup and format string population on the registry model instead of the Notification model. This change will make more sense with my next PR - Use `copy()` when setting the format values, as to ensure thread safety, these shouldn't be set on the static instance class in the registry. - Add a base class for notifications, for messages/notifications that fall outside doc building.
This was referenced Feb 5, 2024
humitos
approved these changes
Feb 6, 2024
humitos
added a commit
that referenced
this pull request
Feb 21, 2024
In #11094 we introduce a bug in the rendering because we stopped initializing the Message class with the `format_values` from the `Notification` object itself. That's why all the notifications weren't rendering these values.
humitos
added a commit
that referenced
this pull request
Feb 21, 2024
* Notifications: fix rendering In #11094 we introduce a bug in the rendering because we stopped initializing the Message class with the `format_values` from the `Notification` object itself. That's why all the notifications weren't rendering these values. * Notifications: typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a few fixes and small restructuring to the notification/message classes.
copy()when setting the format values, as to ensure thread safety, these shouldn't be set on the static instance class in the registry.