Some fixes for notifications #11093
Closed
Some fixes for notifications #11093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This includes a few fixes and small restructuring to the notification/message classes. - Centralize message lookup and format string population on the registry model instead of the Notification model. This change will make more sense with my next PR - Use `copy()` when setting the format values, as to ensure thread safety, these shouldn't be set on the static instance class in the registry. - Add a base class for notifications, for messages/notifications that fall outside doc building.
I found myself rebuilding these messages in template code and figured it would be a good excuse to further consolidate the patterns we're using. In short, these messages are emitted at view time and are not saved to the database. The view time logic is similar as notifications however. A few questions stand for me: - I like centering all of our notifications/errors around exceptions, as it retains an opportunity to emit exceptions from wherever we might want to move some of this logic. Arguably, this logic should not exist on a single view and could be moved on to modeling/queryset classes. - I don't have a strong opinion on whether it's important for these messages to exist in the registry. I see arguments for both, but I chose to use the registry so that we can consolidate logic there -- format values and message lookup, etc. I'm looking for input on these patterns. On the template side, the display is now just a simple `if` and template logic similar to the current notification display, using the header/body render methods.
|
Oops, this was the wrong branch, see #11094 instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a few fixes and small restructuring to the notification/message classes.
copy()when setting the format values, as to ensure thread safety, these shouldn't be set on the static instance class in the registry.