Skip to content

Notifications: use Template's Django engine to render them #11024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 11, 2024
Merged

Notifications: use Template's Django engine to render them #11024

merged 3 commits into from
Jan 11, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 10, 2024

Closes #11022

@humitos
Notifications: use Template's Django engine to render them
de42c5e 
We dealt a few times when rendering notifications using simple Python's
`.format()` and we changed our mind to use Django's engine instead.

Closes #11022
@humitos
Revert #11018 and use instance.name again
0a0cf3c
@humitos humitos requested review from agjohnson and stsewd January 10, 2024 15:56
@humitos humitos requested a review from a team as a code owner January 10, 2024 15:56
@humitos humitos merged commit 34ccbad into main Jan 11, 2024
@humitos humitos deleted the humitos/render-notifications-engine branch January 11, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

@stsewd stsewd stsewd approved these changes

Assignees

@humitos humitos

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notifications: think more about how to render them safely
3 participants
@humitos @agjohnson @stsewd