Skip to content

Notifications: use instance.slug instead of instance.name #11018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 10, 2024
Merged

Notifications: use instance.slug instead of instance.name #11018

merged 1 commit into from
Jan 10, 2024

Conversation

humitos
Copy link
Member

@humitos humitos commented Jan 9, 2024

We need to escape() some of the values that are controlled by the user before being able to format them.

Related #11016

@humitos
Notifications: use instance.slug instead of instance.name
bf544e1 
We need to `escape()` some of the values that are controlled by the user before
being able to format them.

Related #11016
@humitos humitos added the PR: hotfix Pull request applied as hotfix to release label Jan 9, 2024
@humitos humitos requested a review from a team as a code owner January 9, 2024 17:31
@humitos humitos requested a review from ericholscher January 9, 2024 17:31
agjohnson
agjohnson approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@agjohnson agjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good for a temporary fix 👍

Generally speaking, we shouldn't surface the slug to users, at least like this. It's a rather internal concept.

@humitos humitos mentioned this pull request Jan 10, 2024
Closed
@humitos
Copy link
Member Author

humitos commented Jan 10, 2024

@agjohnson I opened #11022 to track this issue and discuss it a little more if we need.

@humitos humitos merged commit 4a864c3 into main Jan 10, 2024
@humitos humitos deleted the humitos/notifications-instance-message branch January 10, 2024 08:46
humitos added a commit that referenced this pull request Jan 10, 2024
@humitos
Revert #11018 and use instance.name again
0a0cf3c
humitos added a commit that referenced this pull request Jan 11, 2024
@humitos
Notifications: use Template's Django engine to render them (#11024)
34ccbad 
* Notifications: use `Template`'s Django engine to render them

We dealt a few times when rendering notifications using simple Python's
`.format()` and we changed our mind to use Django's engine instead.

Closes #11022

* Revert #11018 and use `instance.name` again

* Update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agjohnson agjohnson agjohnson approved these changes

@ericholscher ericholscher Awaiting requested review from ericholscher ericholscher is a code owner automatically assigned from readthedocs/backend

Assignees

@humitos humitos

Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@humitos @agjohnson