Skip to content

Requirements: revert upgrade to psycopg==3.x #10713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 12, 2023
Merged

Conversation

humitos
Copy link
Member

@humitos humitos commented Sep 5, 2023

This package works fine and the upgrade was transparent. However, it seems that New Relic agent is not prepared to collect data from v3.x and send it to their servers.

https://docs.newrelic.com/docs/apm/agents/python-agent/getting-started/instrumented-python-packages/#instance-details

The Python agent should be able to track database queries for any Python
DB-API 2.0 compliant modules

psycopg3 is compatible with DB-API 2.0, but for some reason doesn't work. I'm reverting it for now and we can take a look later.

Note this commit also upgrades Django, due to a security issue that was reported:

https://docs.djangoproject.com/en/4.2/releases/4.2.5/

Reverts #10667

This package works fine and the upgrade was transparent. However, it seems that
New Relic agent is not prepared to collect data from v3.x and send it to their
servers.

https://docs.newrelic.com/docs/apm/agents/python-agent/getting-started/instrumented-python-packages/#instance-details

> The Python agent should be able to track database queries for any Python
> DB-API 2.0 compliant modules

`psycopg3` is compatible with DB-API 2.0, but for some reason doesn't work.
I'm reverting it for now and we can take a look later.

Note this commit also upgrades Django, due to a security issue that was
reported:

https://docs.djangoproject.com/en/4.2/releases/4.2.5/

Reverts #10667
@humitos humitos requested a review from a team as a code owner September 5, 2023 17:49
@humitos humitos requested a review from stsewd September 5, 2023 17:49
@humitos humitos added the PR: hotfix Pull request applied as hotfix to release label Sep 5, 2023
@humitos humitos enabled auto-merge (squash) September 12, 2023 10:47
@humitos humitos merged commit 9409f57 into main Sep 12, 2023
@humitos humitos deleted the humitos/psycopg3-revert branch September 12, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: hotfix Pull request applied as hotfix to release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants