Requirements: use psycopg3
#10667
Merged
Requirements: use psycopg3
#10667
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now we are on Django 4.2 we can use the latest version of psycopg. Closes #10596
stsewd
approved these changes
Aug 31, 2023
|
I'm merging this. If something fails we will notice it immediately when deploying web-extra |
humitos
added a commit
that referenced
this pull request
Sep 5, 2023
This package works fine and the upgrade was transparent. However, it seems that New Relic agent is not prepared to collect data from v3.x and send it to their servers. https://docs.newrelic.com/docs/apm/agents/python-agent/getting-started/instrumented-python-packages/#instance-details > The Python agent should be able to track database queries for any Python > DB-API 2.0 compliant modules `psycopg3` is compatible with DB-API 2.0, but for some reason doesn't work. I'm reverting it for now and we can take a look later. Note this commit also upgrades Django, due to a security issue that was reported: https://docs.djangoproject.com/en/4.2/releases/4.2.5/ Reverts #10667
humitos
added a commit
that referenced
this pull request
Sep 5, 2023
This package works fine and the upgrade was transparent. However, it seems that New Relic agent is not prepared to collect data from v3.x and send it to their servers. https://docs.newrelic.com/docs/apm/agents/python-agent/getting-started/instrumented-python-packages/#instance-details > The Python agent should be able to track database queries for any Python > DB-API 2.0 compliant modules `psycopg3` is compatible with DB-API 2.0, but for some reason doesn't work. I'm reverting it for now and we can take a look later. Note this commit also upgrades Django, due to a security issue that was reported: https://docs.djangoproject.com/en/4.2/releases/4.2.5/ Reverts #10667
humitos
added a commit
that referenced
this pull request
Sep 5, 2023
This package works fine and the upgrade was transparent. However, it seems that New Relic agent is not prepared to collect data from v3.x and send it to their servers. https://docs.newrelic.com/docs/apm/agents/python-agent/getting-started/instrumented-python-packages/#instance-details > The Python agent should be able to track database queries for any Python > DB-API 2.0 compliant modules `psycopg3` is compatible with DB-API 2.0, but for some reason doesn't work. I'm reverting it for now and we can take a look later. Note this commit also upgrades Django, due to a security issue that was reported: https://docs.djangoproject.com/en/4.2/releases/4.2.5/ Reverts #10667
humitos
added a commit
that referenced
this pull request
Sep 12, 2023
* Requirements: revert upgrade to `psycopg==3.x` This package works fine and the upgrade was transparent. However, it seems that New Relic agent is not prepared to collect data from v3.x and send it to their servers. https://docs.newrelic.com/docs/apm/agents/python-agent/getting-started/instrumented-python-packages/#instance-details > The Python agent should be able to track database queries for any Python > DB-API 2.0 compliant modules `psycopg3` is compatible with DB-API 2.0, but for some reason doesn't work. I'm reverting it for now and we can take a look later. Note this commit also upgrades Django, due to a security issue that was reported: https://docs.djangoproject.com/en/4.2/releases/4.2.5/ Reverts #10667 * Update packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we are on Django 4.2 we can use the latest version of psycopg.
Closes #10596