Skip to content

Addons: allow to be extended by corporate #10705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

humitos
Copy link
Member

@humitos humitos commented Sep 4, 2023

  • Define _get_project and _get_version as individual methods because these are required by the API permissions.
  • Use user= attribute when performing the query for the versions to be displayed in the flyout.

Requires #10704

* Define `_get_project` and `_get_version` as individual methods because these
  are required by the API permissions.
* Use `user=` attribute when performing the query for the versions to be
  displayed in the flyout.

Requires #10704
@humitos
Copy link
Member Author

humitos commented Sep 5, 2023

I'm merging this since I want to deploy it today. @stsewd I'd appreciate your review here anyways. I can make the changes in a following PR if anything.

@humitos humitos merged commit 125d81f into humitos/cache-addons-endpoint Sep 5, 2023
@humitos humitos deleted the humitos/addons-business branch September 5, 2023 07:48
humitos added a commit that referenced this pull request Sep 5, 2023
* Addons: add `CDN-Tags` to endpoint and auto-purge cache

It follows a similar approach than `FooterHTML` API by adding `rtd-addons` CDN
tag and uses the same signals logic from `readthedocs-ext` to purge the cache
on different events.

Closes #10694

* Addons: allow to be extended by corporate (#10705)

* Define `_get_project` and `_get_version` as individual methods because these
  are required by the API permissions.
* Use `user=` attribute when performing the query for the versions to be
  displayed in the flyout.

Requires #10704
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant