Addons: add CDN-Tags to endpoint and auto-purge cache
#10704
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It follows a similar approach than `FooterHTML` API by adding `rtd-addons` CDN tag and uses the same signals logic from `readthedocs-ext` to purge the cache on different events. Closes #10694
humitos
added a commit
that referenced
this pull request
Sep 4, 2023
* Define `_get_project` and `_get_version` as individual methods because these are required by the API permissions. * Use `user=` attribute when performing the query for the versions to be displayed in the flyout. Requires #10704
humitos
commented
Sep 4, 2023
* Define `_get_project` and `_get_version` as individual methods because these are required by the API permissions. * Use `user=` attribute when performing the query for the versions to be displayed in the flyout. Requires #10704
|
I'm merging this since I want to deploy it today. @stsewd I'd appreciate your review here anyways. I can make the changes in a following PR if anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It follows a similar approach than
FooterHTMLAPI by addingrtd-addonsCDN tag and uses the same signals logic fromreadthedocs-extto purge the cache on different events.Closes #10694