Build: always use gvisor Docker runtime
#10469
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the feature flag to decide whether or not Docker should use `gVisor`. This is currently enabled by default to all the projects since last week, so I think we are safe to remove it since it has been working fine.
agjohnson
approved these changes
Jun 26, 2023
stsewd
approved these changes
Jun 26, 2023
|
This is ready to be merged, but we will wait a couple of weeks before doing so. We enabled gVisor for all projects some days ago. I'll come back to this PR after these weeks and merge it. |
|
I'm merging. This is going out next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the feature flag to decide whether or not Docker should use
gVisor. This is currently enabled by default to all the projects since last week, so I think we are safe to remove it since it has been working fine.Related #9779