Build: always use gvisor Docker runtime (#10469)

* Build: always use `gvisor` Docker runtime

Remove the feature flag to decide whether or not Docker should use `gVisor`.
This is currently enabled by default to all the projects since last week, so I
think we are safe to remove it since it has been working fine.

* Mention gVisor in the installation guide

Author: humitos

docs/dev/install.rst

@@ -59,6 +59,8 @@ Set up your environment
 
       pip install -r common/dockerfiles/requirements.txt
 
+#. Set up gVisor following :doc:`rtd-dev:guides/gvisor`.
+
 #. Build the Docker image for the servers:
 
    .. warning::

readthedocs/doc_builder/director.py

@@ -140,14 +140,12 @@ def create_vcs_environment(self):
         )
 
     def create_build_environment(self):
-        use_gvisor = self.data.config.using_build_tools and self.data.config.build.jobs
         self.build_environment = self.data.environment_class(
             project=self.data.project,
             version=self.data.version,
             config=self.data.config,
             build=self.data.build,
             environment=self.get_build_env_vars(),
-            use_gvisor=use_gvisor,
             api_client=self.data.api_client,
         )
 

readthedocs/doc_builder/environments.py

@@ -564,15 +564,11 @@ class DockerBuildEnvironment(BaseBuildEnvironment):
 
     def __init__(self, *args, **kwargs):
         container_image = kwargs.pop("container_image", None)
-        self.use_gvisor = kwargs.pop("use_gvisor", False)
         super().__init__(*args, **kwargs)
         self.client = None
         self.container = None
         self.container_name = self.get_container_name()
 
-        if self.project.has_feature(Feature.DOCKER_GVISOR_RUNTIME):
-            self.use_gvisor = True
-
         # Decide what Docker image to use, based on priorities:
         # The image set by user or,
         if self.config and self.config.docker_image:
@@ -799,12 +795,10 @@ def create_container(self):
         """Create docker container."""
         client = self.get_client()
         try:
-            docker_runtime = "runsc" if self.use_gvisor else None
             log.info(
                 'Creating Docker container.',
                 container_image=self.container_image,
                 container_id=self.container_id,
-                docker_runtime=docker_runtime,
             )
             self.container = client.create_container(
                 image=self.container_image,
@@ -819,7 +813,7 @@ def create_container(self):
                 host_config=self.get_container_host_config(),
                 detach=True,
                 user=settings.RTD_DOCKER_USER,
-                runtime=docker_runtime,
+                runtime="runsc",  # gVisor runtime
             )
             client.start(container=self.container_id)
         except (DockerAPIError, ConnectionError) as exc:

readthedocs/projects/models.py

@@ -1909,7 +1909,6 @@ def add_features(sender, **kwargs):
     CONDA_APPEND_CORE_REQUIREMENTS = "conda_append_core_requirements"
     ALL_VERSIONS_IN_HTML_CONTEXT = "all_versions_in_html_context"
     CDN_ENABLED = "cdn_enabled"
-    DOCKER_GVISOR_RUNTIME = "gvisor_runtime"
     RECORD_404_PAGE_VIEWS = "record_404_page_views"
     ALLOW_FORCED_REDIRECTS = "allow_forced_redirects"
     DISABLE_PAGEVIEWS = "disable_pageviews"
@@ -1982,10 +1981,6 @@ def add_features(sender, **kwargs):
                 "are enabled."
             ),
         ),
-        (
-            DOCKER_GVISOR_RUNTIME,
-            _("Build: Use Docker gVisor runtime to create build container."),
-        ),
         (
             RECORD_404_PAGE_VIEWS,
             _("Proxito: Record 404s page views."),