Revert 92a7182af42e26cab01265d2cc06fc7832832689 #10158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericholscher
force-pushed
the
revert-pdf
branch
from
5fa7aa8 to
abf908d
Compare
benjaoming
approved these changes
Mar 16, 2023
| "Our code has recently changed to fail the entire build on PDF errors, " | ||
| "where we used to pass the build when a PDF was created. " | ||
| "Please contact us if you need help understanding this error." | ||
| ) |
There was a problem hiding this comment.
Ah! Once we re-revert, this would be a great place to add helpful tips on how to get it working again.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10113