doc_builder: possibly contradictory exception message #10148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

silopolis opened this issue Mar 14, 2023 · 2 comments

Contributor

silopolis commented Mar 14, 2023 •

edited

Loading

Isn't the explanation contradictory? Shouldn't it be 'fail the entire build on NON PDF errors'?

https://github.com/readthedocs/readthedocs.org/blob/main/readthedocs/doc_builder/exceptions.py#L63-L64

Member

humitos commented Mar 20, 2023

@silopolis it seems the link points to a different exception than the one you are referring to. Can you expand on this?

Member

stsewd commented Mar 20, 2023

This change was reverted in #10158.

stsewd closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment