Build: remove all reshim commands
#10134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not needed anymore because the `reshim` happens automatically inside each of the `asdf` plugins now. The new version of the `asdf` and its plugin handle this in a better way than how we are handling it here. Requires: readthedocs/readthedocs-docker-images#189
stsewd
approved these changes
Mar 13, 2023
|
Before merging this PR, we need to finish the deploy for the builders we started but we had to revert. Moving back to "In progress". |
|
Marking as blocked because I just read
from https://github.com/asdf-community/asdf-python and called my attention. We will need to ask them if this is working as we expect or not. |
|
I'm closing this for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not needed anymore because the
reshimhappens automatically inside each of theasdfplugins now.The new version of the
asdfand its plugin handle this in a better way than how we are handling it here.Requires: readthedocs/readthedocs-docker-images#189