asdf: update asdf and all its plugins
#189
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow us to be smarter about _when to reshim_. With this update, it will be handled automatically by `asdf` and we won't require a custom chunk of code in our application: https://github.com/readthedocs/readthedocs.org/blob/a5965129c61b9bcdff2f2098ff7ce7f8c093dc74/readthedocs/doc_builder/director.py#L373-L386 Currently, multi-lines commands that install something with `pip` and immediate after that, inside the multi-line command try to use the executable installed, fail because it's not automatically reshimed. By reshiming at `asdf` level, this case will be solved. Related: readthedocs/readthedocs.org#9150 (comment) Related: asdf-community/asdf-python#136
|
Once this PR gets merged, we need to re-build the Docker images and update them to Docker Hub. Besides, we should re-build the tools as well to avoid any potential incompatibilities with new |
|
This upgrade may solve readthedocs/readthedocs.org#10108 as well, since we will be using a newer Ubuntu 22.04 patch version. |
|
I created a Deploy Key from CircleCI so the tests start working again. We need to update the |
|
I tested it locally after re-building the Docker image and it works great:
We don't require the |
humitos
added a commit
to readthedocs/readthedocs.org
that referenced
this pull request
Mar 9, 2023
They are not needed anymore because the `reshim` happens automatically inside each of the `asdf` plugins now. The new version of the `asdf` and its plugin handle this in a better way than how we are handling it here. Requires: readthedocs/readthedocs-docker-images#189
stsewd
approved these changes
Mar 13, 2023
humitos
added a commit
that referenced
this pull request
Mar 21, 2023
I missed to update this file in #189
ericholscher
pushed a commit
that referenced
this pull request
Mar 21, 2023
I missed to update this file in #189
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow us to be smarter about when to reshim.
With this update, it will be handled automatically by
asdfand we won't require a custom chunk of code in our application:https://github.com/readthedocs/readthedocs.org/blob/a5965129c61b9bcdff2f2098ff7ce7f8c093dc74/readthedocs/doc_builder/director.py#L373-L386
Currently, multi-lines commands that install something with
pipand immediate after that, inside the multi-line command try to use the executable installed, fail because it's not automatically reshimed.By reshiming at
asdflevel, this case will be solved.Related: readthedocs/readthedocs.org#9150 (comment)
Related: asdf-community/asdf-python#136
Related: readthedocs/readthedocs.org#10103