Unable to build latest version from a tag

[davfsa]

Details

• Read the Docs project URL: https://readthedocs.org/projects/hikari-py
• Build URL (if applicable): https://readthedocs.org/projects/hikari-py/builds/21916140/
• Read the Docs username (if applicable): https://readthedocs.org/profiles/davfsa

Expected Result

Documentation is properly built, as it used to be the case.

I unfortunately haven't made a release in months, so I only noticed this recently. I could not find any git commits that could be linked to this apart from maybe this code, but this definitely used to work

Actual Result

Unable to build latest from a tag, as it fails at checkout

[stsewd]

ha! Looks like we always expect latest to be a branch (even the option is called "Default branch"), but we aren't enforcing it

readthedocs.org/readthedocs/projects/forms.py

Lines 272 to 279 in 53e21bb

	versions_choices = self.instance.versions(manager=INTERNAL).filter(
	machine=False).values_list('verbose_name', flat=True)
	self.fields['default_branch'].widget = forms.Select(
	choices=[default_choice] + list(
	zip(versions_choices, versions_choices)
	),
	)

We are given users the option to select a tag!

This was working previously because we were treating tags and branches kind of the same, but we aren't doing that anymore.

Not sure about the fix here, probably more users were relying on us allowing latest to be a tag...

[stsewd]

I'll check tomorrow if this can be fixed, so our code accepts both, tags and branches as latest.

[stsewd]

The fix was released today, latest can now point to a tag again.

https://readthedocs.org/projects/hikari-py/builds/22038735/