Skip to content

Commit 53e21bb

Browse files
humitosstsewd
andauthored
FooterAPI: use organizations to test private versions
This is to fix tests on .com --------- Co-authored-by: Santos Gallegos <[email protected]>
1 parent aee3f49 commit 53e21bb

File tree

1 file changed

+11
-2
lines changed

1 file changed

+11
-2
lines changed

readthedocs/rtd_tests/tests/test_footer.py

+11-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
from unittest import mock
22

33
import pytest
4+
from django.contrib.auth.models import User
45
from django.contrib.sessions.backends.base import SessionBase
56
from django.http import HttpResponse
67
from django.test import TestCase, override_settings
@@ -12,6 +13,7 @@
1213
from readthedocs.builds.constants import BRANCH, EXTERNAL, LATEST, TAG
1314
from readthedocs.builds.models import Version
1415
from readthedocs.core.middleware import ReadTheDocsSessionMiddleware
16+
from readthedocs.organizations.models import Organization
1517
from readthedocs.projects.constants import GITHUB_BRAND, GITLAB_BRAND, PRIVATE, PUBLIC
1618
from readthedocs.projects.models import Project
1719
from readthedocs.subscriptions.constants import TYPE_CNAME
@@ -335,7 +337,11 @@ def setUp(self):
335337
self.pip = Project.objects.get(slug="pip")
336338
self.pip.versions.update(built=True)
337339
self.pip.show_version_warning = True
340+
self.pip.privacy_level = PUBLIC
338341
self.pip.save()
342+
self.pip.versions.update(privacy_level=PUBLIC)
343+
344+
self.user = User.objects.get(username="eric")
339345

340346
def test_highest_version_from_stable(self):
341347
base_version = self.pip.get_stable_version()
@@ -446,14 +452,17 @@ def test_highest_version_without_tags(self):
446452
returned_data = get_version_compare_data(self.pip, base_version)
447453
self.assertDictEqual(valid_data, returned_data)
448454

455+
@override_settings(
456+
RTD_ALLOW_ORGANIZATIONS=True,
457+
)
449458
def test_private_highest_version(self):
459+
get(Organization, projects=[self.pip], owners=[self.user])
450460
self.pip.versions.update(privacy_level=PRIVATE)
451-
owner = self.pip.users.first()
452461
base_version = self.pip.versions.get(slug="0.8")
453462
returned_data = get_version_compare_data(self.pip, base_version)
454463
self.assertTrue(returned_data["is_highest"])
455464

456-
returned_data = get_version_compare_data(self.pip, base_version, user=owner)
465+
returned_data = get_version_compare_data(self.pip, base_version, user=self.user)
457466
valid_data = {
458467
"project": "Version 0.8.1 of Pip (19)",
459468
"url": "https://pip.readthedocs.io/en/0.8.1/",

0 commit comments

Comments
 (0)